Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more robust to issues with the flowsheets #55

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dangunter
Copy link
Member

@dangunter dangunter commented Oct 25, 2024

Fixes #54 , #57

Changes

For Issue #54:

  • Check if attribute exists, if so proceed
  • If not, set the label to "None"
  • Could issue a warning, but that would probably be ignored in this context and anyways there will be warnings issued from the idaes core code that builds the stream table earlier in the processing.

For Issue #57:

  • Add 'strict' mode to validation, off by default
  • Change failure for missing components in layout to warning in default (non-strict) mode

For general amusement:

  • added some debug statements into the web server

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@dangunter dangunter requested a review from OOAmusat October 25, 2024 17:28
@dangunter dangunter changed the title Fix for missing attribute on a stream Be more robust to issues with the flowsheets Oct 31, 2024
@dangunter dangunter requested a review from CopyDemon October 31, 2024 16:14
@dangunter dangunter self-assigned this Oct 31, 2024
@dangunter dangunter added bug Something isn't working enhancement New feature or request labels Oct 31, 2024
@lbianchi-lbl lbianchi-lbl added the Priority:Normal Normal Priority Issue or PR label Oct 31, 2024
@ksbeattie ksbeattie added Priority:Low Low Priority Issue or PR and removed Priority:Normal Normal Priority Issue or PR labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request Priority:Low Low Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle absence of define_display_vars attribute
3 participants